FFS is crashing for one particular job!

[Zenju]

Let me know if there is further interest to get this problem fixed. I won't
keep the test setup for too long.

[saicode]

Sorry for the late reply. I have been busy in traveling and the that PC is at
home.

I will get back to with the "process explorer call stack" tonight when I get
home.

[saicode]

Here you go:
http://ge.tt/7KCXJEN?c

[Zenju]

Thanks for the update! It seems my validity check does not catch the invalid
date it is given. I have therefore enhanced the popup message you are seeing
with details about the data:

[404, Invalid URL: http://freefilesync.sourceforge.net/FFS_5.7_beta_test2.rar]

Please send me a screenshot of the new popup text and also the "exception.dmp"
that is created. I changed a few things in the dump creation routine, perhaps
it is working now.

[saicode]

Here you go:
http://ge.tt/34fauKN?c

[Zenju]

I'm not able to reproduce the error condition with the values from the popup
message, which could be due to differences in the version of the CRT. Anyway,
I think the problem is related to the year which is 2199. If I change the year
to 10000 I'm finally able to reproduce it! Clearly a year 10000 is not an
invalid parameter; in any case it's a runtime parameter and not a design-time
one. So MS' decision to have the application crash on a runtime parameter
which is NOT even in conflict with the C standard definition of "struct tm"
which places no bounds on the "year" is a plain implementation bug.
Since I cannot do the parameter validation myself since MS does not adhere to
the standard, the only solution is to disable these kinds of asserts entirely
(thanks MS for providing the means to do so) and have the time formatting
function fail, which is at least reasonable behavior according to the function
contract.
This is what I have done in the new beta version. I assume the problem is
finally fixed:

[404, Invalid URL: http://freefilesync.sourceforge.net/FreeFileSync_5.8_beta_setup.exe]

[saicode]

Hi ZenZu

This one seems to be working! Although I get a conflict popup and the
thunderbolt marked files. What’s surprising for me that in the other job which
syncs the very same files (from left to another directory) does not show the
conflicts!

But anyhow, it’s working. Here is one screenshot just in case you want to
refer to [http://ge.tt/2YgtQNN/v/0?c.](http://ge.tt/2YgtQNN/v/0?c.)

Thanks a lot for such long painstaking efforts to resolve this issue!!




One more thing!

Because I have have really benefited by FFS and humbled by your personal
attention for helping me out, I would like to return the favor by contributing
to your FFS project.

Even though FFS has become one of my indispensable program like many other
users, in my humble opinion the GUI (mainly the Icons) is quite dated and can
be improved to make the program even more attractive.

If you would like I could suggest some more options (just visual, using more
apt icons and if possible colors etc.) for FFS.

I am not specifically UI designer (I am an Industrial designer by profession),
but I have to do UI design as part of some projects and I believe I can help
to make FFS visually much better.

You could find some of my work at www.saikatbiswas.com.
Again, it’s mostly industrial design but it may give you some idea of my
taste.

Looking forward to hearing from you!

[Zenju]

> conflict popup and the thunderbolt marked files


Just mouse-hover over them with the mouse and have a look at the tooltip
description. I'd expect something like "File %x has an invalid date!"


> contributing to your FFS project.


I gladly accept your offer! :) I like your style, elegant, yet not
unnecessarily fancy; this should fit nicely for FFS. Just get in touch with me
via email and we'll discuss the details. I have a quite clear set of
requirements for the GUI, and having done all the visual design, also a fair
respect on the amount of detail work required. There is definitively room for
improvement, so I'm curioius how the workover will turn out.

[saicode]

The tool-tip says "Both sides have changed since last synchronization "
Here is a screenshot http://ge.tt/7U1YkON/v/0?c

Thanks for accepting my offer. I am not able to find your email address.
Sent you an a message by Sourceforge with my email ID.

[Zenju]

> Both sides have changed since last synchronization


This conflict is due to the automatic mode being unable to set a sync
direction. However I would expect a categorization conflict, too, since FFS
handles files with a date at least one year in the future as conflicting. This
conflict can be seen if you toggle the middle grid to categorization view, via
F8 or right click middle grid's column label.

[saicode]

Hi Zenju,

Did you get my message with email id?

I am looking forward to starting the GUI work.

[Zenju]

Yes, and I have sent an answer to the gmail address. Maybe it's in SPAM
folder?