Patch for tooltip fix

[bgstack15]

Dear Zenju,

Thank you for the latest release of this project! I have investigated how to suppress (on GNU/Linux) the taskbar entry for the tooltip that appears when the user mouses over the left-or-right indicator in the middle of the file grid. Would you please consider incorporating this patch into the upstream:

--- a/wx+/tooltip.cpp
+++ b/wx+/tooltip.cpp
@@ -9,6 +9,7 @@
 #include <wx/sizer.h>
 #include <wx/statbmp.h>
 #include <wx/settings.h>
+#include <wx/frame.h>
 #include <wx/app.h>
 #include "image_tools.h"
 #include "bitmap_button.h"
@@ -27,7 +28,7 @@ const int TIP_WINDOW_OFFSET_DIP = 30;
 class Tooltip::TooltipDlgGenerated : public wxDialog
 {
 public:
-    TooltipDlgGenerated(wxWindow* parent) : wxDialog(parent, wxID_ANY, L"" /*title*/, wxDefaultPosition, wxDefaultSize, 0 /*style*/)
+    TooltipDlgGenerated(wxWindow* parent) : wxDialog(parent, wxID_ANY, L"" /*title*/, wxDefaultPosition, wxDefaultSize, wxFRAME_NO_TASKBAR /*style*/)
     {
         //Suse Linux/X11: needs parent window, else there are z-order issues
 


I'm sorry, I don't have any ability to compile this on Windows to see if it is safe there. Docs page https://docs.wxwidgets.org/trunk/classwx_frame.html did not indicate it was particularly dangerous given the lack of the minimize button on the tooltip "window."

[Zenju]

I'm not seeing any taskbar entry for the popup dialog (tested in Centos, Ubuntu, Mint, openSUSE) Are you talking about the little main dialog flash when the popup dialog is shown? For this the wxFRAME_NO_TASKBAR does nothing. Also wxFRAME_NO_TASKBAR is documented to be "wxFrame-specific (i.e. not for wxDialog) styles"

[bgstack15]

I use fluxbox, and I wonder if that is the reason I always see a new window on the iconbar (taskbar) when I show the tooltip for the center column of the file grid. Perhaps more advanced window managers suppress the taskbar entry, but I needed this patch for my setup.